benhamilton marked 3 inline comments as done.
benhamilton added a comment.
Thanks for the review!
================
Comment at: lib/Format/Format.cpp:765
GoogleStyle.ColumnLimit = 100;
+ GoogleStyle.BinPackObjCProtocolList = FormatStyle::BPS_Never;
}
----------------
stephanemoore wrote:
> I propose that we defer this to a future commit while we establish consensus
> at Google.
Moved to D42708.
================
Comment at: unittests/Format/FormatTestObjC.cpp:325-334
+ Style.ColumnLimit = 40;
+ // BinPackParameters should be true by default.
+ verifyFormat("void eeeeeeee(int eeeee, int eeeee,\n"
+ " int eeeee, int eeeee);\n");
+ // BinPackObjCProtocolList should be BPS_Never by default.
+ verifyFormat("@interface fffffffffffff () <\n"
+ " fffffffffffff,\n"
----------------
stephanemoore wrote:
> Similar to my other comment, I propose deferring the changes to Google style
> to a future commit.
Moved to D42708.
Repository:
rC Clang
https://reviews.llvm.org/D42650
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
