ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment.
All comments should be addressed now. Let me know if I missed anything else. ================ Comment at: clangd/threading/TUScheduler.h:1 +//===--- TUScheduler.h -------------------------------------------*-C++-*-===// +// ---------------- ilya-biryukov wrote: > sammccall wrote: > > this class needs tests > Will do :-( Added a simple test for it. Please take a look and let me know if you have more ideas on how we should test it. ================ Comment at: clangd/threading/ThreadPool.h:1 +//===--- ThreadPool.h --------------------------------------------*- C++-*-===// +// ---------------- ilya-biryukov wrote: > sammccall wrote: > > this class needs tests > Will do :-( We have `ClangdThreadingTest.StressTest` and `TUSchedulerTests` that both run concurrent operations on `ThreadPool`. As you pointed out, this should provide enough coverage for `ThreadPool`, so I didn't create any extra tests for it. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42174 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits