sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land.
This is really great. Just one test nit. ================ Comment at: unittests/clangd/ThreadingTests.cpp:34 + + scheduleIncrements(); + Tasks.waitForAll(); ---------------- The current test passes if `runAsync` is synchronous. I'd suggest scheduling while holding a mutex that prevents the tasks from getting to the point of incrementing the counter, (and maybe checking that the counter is 0 after scheduling for clarity). Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42573 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
