modocache updated this revision to Diff 133129. modocache added a comment. Prevent coroutine parameter stores from being moved, rely on https://reviews.llvm.org/D43000 instead.
Repository: rC Clang https://reviews.llvm.org/D42606 Files: lib/Sema/SemaCoroutine.cpp test/CodeGenCoroutines/coro-alloc.cpp test/SemaCXX/coroutines.cpp
Index: test/SemaCXX/coroutines.cpp =================================================================== --- test/SemaCXX/coroutines.cpp +++ test/SemaCXX/coroutines.cpp @@ -781,6 +781,68 @@ } template coro<good_promise_13> dependent_uses_nothrow_new(good_promise_13); +struct good_promise_custom_new_operator { + coro<good_promise_custom_new_operator> get_return_object(); + suspend_always initial_suspend(); + suspend_always final_suspend(); + void return_void(); + void unhandled_exception(); + void *operator new(unsigned long, double, float, int); +}; + +coro<good_promise_custom_new_operator> +good_coroutine_calls_custom_new_operator(double, float, int) { + co_return; +} + +struct bad_promise_mismatched_custom_new_operator { + coro<bad_promise_mismatched_custom_new_operator> get_return_object(); + suspend_always initial_suspend(); + suspend_always final_suspend(); + void return_void(); + void unhandled_exception(); + // expected-note@+1 {{candidate function not viable: requires 4 arguments, but 1 was provided}} + void *operator new(unsigned long, double, float, int); +}; + +coro<bad_promise_mismatched_custom_new_operator> +bad_coroutine_calls_mismatched_custom_new_operator(double) { + // expected-error@-1 {{no matching function for call to 'operator new'}} + co_return; +} + +struct bad_promise_throwing_custom_new_operator { + static coro<bad_promise_throwing_custom_new_operator> get_return_object_on_allocation_failure(); + coro<bad_promise_throwing_custom_new_operator> get_return_object(); + suspend_always initial_suspend(); + suspend_always final_suspend(); + void return_void(); + void unhandled_exception(); + // expected-error@+1 {{'operator new' is required to have a non-throwing noexcept specification when the promise type declares 'get_return_object_on_allocation_failure()'}} + void *operator new(unsigned long, double, float, int); +}; + +coro<bad_promise_throwing_custom_new_operator> +bad_coroutine_calls_throwing_custom_new_operator(double, float, int) { + // expected-note@-1 {{call to 'operator new' implicitly required by coroutine function here}} + co_return; +} + +struct good_promise_noexcept_custom_new_operator { + static coro<good_promise_noexcept_custom_new_operator> get_return_object_on_allocation_failure(); + coro<good_promise_noexcept_custom_new_operator> get_return_object(); + suspend_always initial_suspend(); + suspend_always final_suspend(); + void return_void(); + void unhandled_exception(); + void *operator new(unsigned long, double, float, int) noexcept; +}; + +coro<good_promise_noexcept_custom_new_operator> +good_coroutine_calls_noexcept_custom_new_operator(double, float, int) { + co_return; +} + struct mismatch_gro_type_tag1 {}; template<> struct std::experimental::coroutine_traits<int, mismatch_gro_type_tag1> { Index: test/CodeGenCoroutines/coro-alloc.cpp =================================================================== --- test/CodeGenCoroutines/coro-alloc.cpp +++ test/CodeGenCoroutines/coro-alloc.cpp @@ -106,6 +106,34 @@ co_return; } +struct promise_matching_placement_new_tag {}; + +template<> +struct std::experimental::coroutine_traits<void, promise_matching_placement_new_tag, int, float, double> { + struct promise_type { + void *operator new(unsigned long, promise_matching_placement_new_tag, + int, float, double); + void get_return_object() {} + suspend_always initial_suspend() { return {}; } + suspend_always final_suspend() { return {}; } + void return_void() {} + }; +}; + +// CHECK-LABEL: f1a( +extern "C" void f1a(promise_matching_placement_new_tag, int x, float y , double z) { + // CHECK: %[[ID:.+]] = call token @llvm.coro.id(i32 16 + // CHECK: %[[SIZE:.+]] = call i64 @llvm.coro.size.i64() + // CHECK: store i32 %x, i32* %coro.allocate.x.addr, align 4 + // CHECK: %[[INT:.+]] = load i32, i32* %coro.allocate.x.addr, align 4 + // CHECK: store float %y, float* %coro.allocate.y.addr, align 4 + // CHECK: %[[FLOAT:.+]] = load float, float* %coro.allocate.y.addr, align 4 + // CHECK: store double %z, double* %coro.allocate.z.addr, align 8 + // CHECK: %[[DOUBLE:.+]] = load double, double* %coro.allocate.z.addr, align 8 + // CHECK: call i8* @_ZNSt12experimental16coroutine_traitsIJv34promise_matching_placement_new_tagifdEE12promise_typenwEmS1_ifd(i64 %[[SIZE]], i32 %[[INT]], float %[[FLOAT]], double %[[DOUBLE]]) + co_return; +} + struct promise_delete_tag {}; template<> Index: lib/Sema/SemaCoroutine.cpp =================================================================== --- lib/Sema/SemaCoroutine.cpp +++ lib/Sema/SemaCoroutine.cpp @@ -506,24 +506,15 @@ auto RefExpr = ExprEmpty(); auto Move = Moves.find(PD); - if (Move != Moves.end()) { - // If a reference to the function parameter exists in the coroutine - // frame, use that reference. - auto *MoveDecl = - cast<VarDecl>(cast<DeclStmt>(Move->second)->getSingleDecl()); - RefExpr = BuildDeclRefExpr(MoveDecl, MoveDecl->getType(), - ExprValueKind::VK_LValue, FD->getLocation()); - } else { - // If the function parameter doesn't exist in the coroutine frame, it - // must be a scalar value. Use it directly. - assert(!PD->getType()->getAsCXXRecordDecl() && - "Non-scalar types should have been moved and inserted into the " - "parameter moves map"); - RefExpr = - BuildDeclRefExpr(PD, PD->getOriginalType().getNonReferenceType(), - ExprValueKind::VK_LValue, FD->getLocation()); - } - + assert(Move != Moves.end() && + "Coroutine function parameter not inserted into move map"); + // If a reference to the function parameter exists in the coroutine + // frame, use that reference. + auto *MoveDecl = + cast<VarDecl>(cast<DeclStmt>(Move->second)->getSingleDecl()); + RefExpr = + BuildDeclRefExpr(MoveDecl, MoveDecl->getType().getNonReferenceType(), + ExprValueKind::VK_LValue, FD->getLocation()); if (RefExpr.isInvalid()) return nullptr; CtorArgExprs.push_back(RefExpr.get()); @@ -1050,18 +1041,54 @@ const bool RequiresNoThrowAlloc = ReturnStmtOnAllocFailure != nullptr; - // FIXME: Add support for stateful allocators. + // [dcl.fct.def.coroutine]/7 + // Lookup allocation functions using a parameter list composed of the + // requested size of the coroutine state being allocated, followed by + // the coroutine function's arguments. If a matching allocation function + // exists, use it. Otherwise, use an allocation function that just takes + // the requested size. FunctionDecl *OperatorNew = nullptr; FunctionDecl *OperatorDelete = nullptr; FunctionDecl *UnusedResult = nullptr; bool PassAlignment = false; SmallVector<Expr *, 1> PlacementArgs; + // [dcl.fct.def.coroutine]/7 + // "The allocation function’s name is looked up in the scope of P. + // [...] If the lookup finds an allocation function in the scope of P, + // overload resolution is performed on a function call created by assembling + // an argument list." + for (auto *PD : FD.parameters()) { + if (PD->getType()->isDependentType()) + continue; + + // Build a reference to the parameter. + auto PDLoc = PD->getLocation(); + ExprResult PDRefExpr = + S.BuildDeclRefExpr(PD, PD->getOriginalType().getNonReferenceType(), + ExprValueKind::VK_LValue, PDLoc); + if (PDRefExpr.isInvalid()) + return false; + + PlacementArgs.push_back(PDRefExpr.get()); + } S.FindAllocationFunctions(Loc, SourceRange(), /*UseGlobal*/ false, PromiseType, /*isArray*/ false, PassAlignment, PlacementArgs, - OperatorNew, UnusedResult); + OperatorNew, UnusedResult, /*Diagnose*/ false); + + // [dcl.fct.def.coroutine]/7 + // "If no matching function is found, overload resolution is performed again + // on a function call created by passing just the amount of space required as + // an argument of type std::size_t." + if (!OperatorNew && !PlacementArgs.empty()) { + PlacementArgs.clear(); + S.FindAllocationFunctions(Loc, SourceRange(), + /*UseGlobal*/ false, PromiseType, + /*isArray*/ false, PassAlignment, + PlacementArgs, OperatorNew, UnusedResult); + } bool IsGlobalOverload = OperatorNew && !isa<CXXRecordDecl>(OperatorNew->getDeclContext()); @@ -1080,7 +1107,8 @@ OperatorNew, UnusedResult); } - assert(OperatorNew && "expected definition of operator new to be found"); + if (!OperatorNew) + return false; if (RequiresNoThrowAlloc) { const auto *FT = OperatorNew->getType()->getAs<FunctionProtoType>(); @@ -1386,25 +1414,28 @@ if (PD->getType()->isDependentType()) continue; - // No need to copy scalars, LLVM will take care of them. - if (PD->getType()->getAsCXXRecordDecl()) { - ExprResult PDRefExpr = BuildDeclRefExpr( - PD, PD->getType(), ExprValueKind::VK_LValue, Loc); // FIXME: scope? - if (PDRefExpr.isInvalid()) - return false; + ExprResult PDRefExpr = + BuildDeclRefExpr(PD, PD->getType().getNonReferenceType(), + ExprValueKind::VK_LValue, Loc); // FIXME: scope? + if (PDRefExpr.isInvalid()) + return false; - Expr *CExpr = castForMoving(*this, PDRefExpr.get()); + Expr *CExpr = nullptr; + if (PD->getType()->getAsCXXRecordDecl() || + PD->getType()->isRValueReferenceType()) + CExpr = castForMoving(*this, PDRefExpr.get()); + else + CExpr = PDRefExpr.get(); - auto D = buildVarDecl(*this, Loc, PD->getType(), PD->getIdentifier()); - AddInitializerToDecl(D, CExpr, /*DirectInit=*/true); + auto D = buildVarDecl(*this, Loc, PD->getType(), PD->getIdentifier()); + AddInitializerToDecl(D, CExpr, /*DirectInit=*/true); - // Convert decl to a statement. - StmtResult Stmt = ActOnDeclStmt(ConvertDeclToDeclGroup(D), Loc, Loc); - if (Stmt.isInvalid()) - return false; + // Convert decl to a statement. + StmtResult Stmt = ActOnDeclStmt(ConvertDeclToDeclGroup(D), Loc, Loc); + if (Stmt.isInvalid()) + return false; - ScopeInfo->CoroutineParameterMoves.insert(std::make_pair(PD, Stmt.get())); - } + ScopeInfo->CoroutineParameterMoves.insert(std::make_pair(PD, Stmt.get())); } return true; }
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits