MaskRay marked 8 inline comments as done.
MaskRay added inline comments.
================
Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:46
+
+ static const llvm::StringMap<StringRef> Mapping{
+ // [simd.alg]
----------------
hokein wrote:
> consider using `llvm::StringSwitch`?
The list is currently a scaffold and more operations will be added. It may be
more efficient to use a lookup table instead of cascading `.Case("add", ...)`?
================
Comment at: docs/clang-tidy/checks/readability-simd-intrinsics.rst:38
+
+ If set to non-zero, the check will be enabled and it will suggest
``std::experimental`` alternatives. Default is ``0``.
+
----------------
hokein wrote:
> We don't use check's option to enable the check in clang-tidy, if users want
> to enable the check, they need to pass the check explicitly to clang-tidy
> (e.g. -checks="<your-check>"). I'd suggest to remove this option.
Removed.I don't think the option is necessary.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42983
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
