I already reverted this a long time ago, but if Shoaib has a proper fix that would be great On Mon, Feb 26, 2018 at 9:45 PM Adam Nemet <ane...@apple.com> wrote:
> Ah, that should be sufficient. > > > On Feb 26, 2018, at 9:44 PM, Shoaib Meenai <smee...@fb.com> wrote: > > Thanks. I'm building on macOS locally to confirm the original problem and > my fix. > > *From: *<ane...@apple.com> on behalf of Adam Nemet <ane...@apple.com> > *Date: *Monday, February 26, 2018 at 9:42 PM > *To: *Shoaib Meenai <smee...@fb.com> > *Cc: *"cfe-commits@lists.llvm.org" <cfe-commits@lists.llvm.org>, Reid > Kleckner <r...@google.com>, Zachary Turner <ztur...@google.com> > *Subject: *Re: r326168 - Attempt to fix greendragon bot after r326141 > > This is the bot with the failure: > > > http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental/46794/#showFailuresLink > <https://urldefense.proofpoint.com/v2/url?u=http-3A__lab.llvm.org-3A8080_green_job_clang-2Dstage1-2Dcmake-2DRA-2Dincremental_46794_-23showFailuresLink&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=OIgCAeO_dFHAJFlsBo7l_qhVKV7niFfyQ0fpICifvN4&s=OEMtPu3dUHXK8327qnfWOSUP62v1F-s_a13X0lqbdJ0&e=> > > But to make matters worse, greendragon is experience some difficulty > fetching from SVN so you might want to wait until things recover. I am not > sure if I will be able to get in touch with Mike Edwards until the morning > PST. > > There may also be llvm bots that exhibit the same problem. You may have > better luck with those in the short term. > > Adam > > > On Feb 26, 2018, at 9:35 PM, Shoaib Meenai <smee...@fb.com> wrote: > > Could you point me to the specific bot that was failing? I've dealt with > that problem before, and it shouldn't be hard to fix, but I wanna monitor > the bot after the fix to make sure it stays green. > > *From: *<ane...@apple.com> on behalf of Adam Nemet <ane...@apple.com> > *Date: *Monday, February 26, 2018 at 9:30 PM > *To: *Shoaib Meenai <smee...@fb.com> > *Cc: *"cfe-commits@lists.llvm.org" <cfe-commits@lists.llvm.org>, Reid > Kleckner <r...@google.com>, Zachary Turner <ztur...@google.com> > *Subject: *Re: r326168 - Attempt to fix greendragon bot after r326141 > > I don’t think we can deal with the slash options: > > clang-7.0: warning: > '/Users/buildslave/jenkins/workspace/apple-clang-master-RA-stage1-cmake-incremental/clang/src/tools/clang/test/Driver/codeview-column-info.c' > treated as the '/U' option [-Wslash-u-filename] > clang-7.0: note: Use '--' to treat subsequent arguments as filenames > clang-7.0: warning: argument unused during compilation: '/Z7' > [-Wunused-command-line-argument] > clang-7.0: warning: argument unused during compilation: ‘-U > sers/buildslave/jenkins/workspace/apple-clang-master-RA-stage1-cmake-incremental/clang/src/tools/clang/test/Driver/codeview-column-info.c' > [-Wunused-command-line-argument] > > Anyhow as I said to Reid, feel free to improve the patch, I am just > bringing back a bot that has been red for hours. > > Adam > > > > On Feb 26, 2018, at 9:22 PM, Shoaib Meenai <smee...@fb.com> wrote: > > This seems bogus to me. CodeView can be generated on any build platform; > it just needs the correct triple, which Reid added in r326144. > > *From: *cfe-commits <cfe-commits-boun...@lists.llvm.org> on behalf of > Adam Nemet via cfe-commits <cfe-commits@lists.llvm.org> > *Reply-To: *Adam Nemet <ane...@apple.com> > *Date: *Monday, February 26, 2018 at 8:51 PM > *To: *"cfe-commits@lists.llvm.org" <cfe-commits@lists.llvm.org> > *Subject: *r326168 - Attempt to fix greendragon bot after r326141 > > Author: anemet > Date: Mon Feb 26 20:49:26 2018 > New Revision: 326168 > > URL: > https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D326168-26view-3Drev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=B6WfLLVLbYMU_571sI0XgBTcOm561QyDCKF2UOJyc-k&s=oqoKnyrAT6kNwxIasdWb7eopGd0q41TFJ5Hxp_eoiZs&e= > Log: > Attempt to fix greendragon bot after r326141 > > Modified: > cfe/trunk/test/Driver/codeview-column-info.c > > Modified: cfe/trunk/test/Driver/codeview-column-info.c > URL: > https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_cfe_trunk_test_Driver_codeview-2Dcolumn-2Dinfo.c-3Frev-3D326168-26r1-3D326167-26r2-3D326168-26view-3Ddiff&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=B6WfLLVLbYMU_571sI0XgBTcOm561QyDCKF2UOJyc-k&s=Hs37wkn2y2OFh6b_DWdNuK_AD--vySi-ptv_d_HDqxg&e= > > ============================================================================== > --- cfe/trunk/test/Driver/codeview-column-info.c (original) > +++ cfe/trunk/test/Driver/codeview-column-info.c Mon Feb 26 20:49:26 2018 > @@ -1,3 +1,4 @@ > +// REQUIRES: system-windows > // Check that -dwarf-column-info does not get added to the cc1 line: > // 1) When -gcodeview is present via the clang or clang++ driver > // 2) When /Z7 is present via the cl driver. > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > > https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_cfe-2Dcommits&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=B6WfLLVLbYMU_571sI0XgBTcOm561QyDCKF2UOJyc-k&s=JTIVfh7ogIVoFYMFdjOK-30TFLWLX39y8q9KItC_xnY&e= > > >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
