sammccall marked 4 inline comments as done.
sammccall added a comment.
Thanks for catching all those things!
================
Comment at: unittests/clangd/TUSchedulerTests.cpp:127
+ /*ASTParsedCallback=*/nullptr,
+ /*UpdateDebounce=*/std::chrono::milliseconds(50));
+ auto Path = testPath("foo.cpp");
----------------
ilya-biryukov wrote:
> I wonder if the default debounce of `500ms` will make other tests (especially
> those that use `ClangdServer`) too slow?
> Maybe we should consider settings a smaller default (maybe even
> `Deadline::zero()`?) and having `500ms` set only by `ClangdLSPServer`?
Good point.
For now I've changed the ClangdServer default to 20ms, with a comment that this
is for tests (to make sure we're testing the "real" codepath).
After pulling out the options struct, I'd like to gave a function that returns
default options to be used in tests (in-memory preambles, fixed number of
threads, short debounce) and make
500ms the "real" default.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43648
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
