ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM, but note the unreachable code comment
================
Comment at: unittests/clangd/FuzzyMatchTests.cpp:35
+
+ friend raw_ostream &operator<<(raw_ostream &OS, const ExpectedMatch &M) {
+ return OS << "'" << M.Word;
----------------
Maybe put operator before `Word` to keep fields grouped together?
================
Comment at: unittests/clangd/FuzzyMatchTests.cpp:37
+ return OS << "'" << M.Word;
+ if (M.Annotated)
+ OS << "' as " << *M.Annotated;
----------------
This code is unreachable. Probably intended to remove `return` from the
previous line?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44003
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
