bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
Hi Sam,
Sorry for the delay. LGTM, I have only minor refactoring suggestion.
Thanks,
Alexey
================
Comment at: lib/CodeGen/CGBlocks.cpp:1065-1067
+ llvm::Value *FuncPtr;
+ if (!CGM.getLangOpts().OpenCL) {
----------------
I think it would be more readable if we merge this if statement with the if
statement at the line #1103.
It's used to initialize FuncPtr for non-OpenCL languages and the first use of
this variable is in the else block of if statement at the line #1103.
If I didn't miss something it should reasonable to combine this if block with
'else' block at the line #1106.
https://reviews.llvm.org/D43783
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
