Thanks! I’ll commit this. From: Eric Christopher [mailto:echri...@gmail.com] Sent: Wednesday, March 7, 2018 12:33 PM To: reviews+d44218+public+fd8ca19cc9985...@reviews.llvm.org Cc: cfe-commits@lists.llvm.org; craig.top...@gmail.com; erich.ke...@intel.com; filcab+llvm.phabrica...@gmail.com; Voss, Matthew; rich...@metafoo.co.uk Subject: Re: [PATCH] D44218: Correct the alignment for the PS4 target
LGTM. On Wed, Mar 7, 2018, 11:02 AM Matthew Voss via Phabricator <revi...@reviews.llvm.org<mailto:revi...@reviews.llvm.org>> wrote: ormris created this revision. ormris added reviewers: rsmith, craig.topper, echristo, erichkeane. See above. Repository: rC Clang https://reviews.llvm.org/D44218 Files: lib/Basic/Targets/OSTargets.h test/Preprocessor/init.c Index: test/Preprocessor/init.c =================================================================== --- test/Preprocessor/init.c +++ test/Preprocessor/init.c @@ -8965,6 +8965,9 @@ // PS4:#define __x86_64__ 1 // PS4:#define unix 1 // +// RUN: %clang_cc1 -x c++ -E -dM -ffreestanding -triple=x86_64-scei-ps4 < /dev/null | FileCheck -match-full-lines -check-prefix PS4-CXX %s +// PS4-CXX:#define __STDCPP_DEFAULT_NEW_ALIGNMENT__ 32UL +// // RUN: %clang_cc1 -E -dM -triple=x86_64-pc-mingw32 < /dev/null | FileCheck -match-full-lines -check-prefix X86-64-DECLSPEC %s // RUN: %clang_cc1 -E -dM -fms-extensions -triple=x86_64-unknown-mingw32 < /dev/null | FileCheck -match-full-lines -check-prefix X86-64-DECLSPEC %s // X86-64-DECLSPEC: #define __declspec{{.*}} Index: lib/Basic/Targets/OSTargets.h =================================================================== --- lib/Basic/Targets/OSTargets.h +++ lib/Basic/Targets/OSTargets.h @@ -485,6 +485,7 @@ default: case llvm::Triple::x86_64: this->MCountName = ".mcount"; + this->NewAlign = 256; break; } }
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits