[PATCH] D44189: [RISCV] Verify the input value of -march=

[Ana Pazos via Phabricator via cfe-commits]

apazos added inline comments.


================
Comment at: lib/Driver/ToolChains/Arch/RISCV.cpp:48
+      break;
+    default:
+      // First letter should be 'i' or 'g'.
----------------
In the switch cases move default to first position.


================
Comment at: lib/Driver/ToolChains/Arch/RISCV.cpp:60
       case 'm':
         Features.push_back("+m");
         break;
----------------
So the subsequent features can appear in any order?


Repository:
  rC Clang

https://reviews.llvm.org/D44189



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits