ilya-biryukov added a comment.

I also came up with a test case, but it breaks because of invalid errors when 
function bodies are skipped. I'll make sure to include it along with a fix for 
the errors in a follow-up patch.



================
Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:3942
       ActOnSkippedFunctionBody(Function);
+      // FIXME: finishing the function body while in an expression evaluation
+      // context seems wrong. Investigate more.
----------------
sammccall wrote:
> (hmm, not sure whether it's better to duplicate or not-duplicate this 
> comment. up to you)
It looks relevant to both sites, so I'd probably keep it. It adds some noise, 
but it's better than having a chance of confusing someone by not including it.


Repository:
  rC Clang

https://reviews.llvm.org/D44439



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to