aaron.ballman added inline comments.
================ Comment at: test/clang-tidy/misc-sizeof-expression.cpp:17 +enum E { E_VALUE = 0 }; + ---------------- Can you add a C++11 test case using `enum class` -- I am worried that the `isInteger()` matcher will return false for that type. Also, I think you should have a test case for `bool`; I think the check will diagnose bool types but I'm not certain there's value in diagnosing those. What do you think? https://reviews.llvm.org/D44231 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits