dim added inline comments.
================ Comment at: CMakeLists.txt:422 + "${CLANG_VERSION_MAJOR}" CACHE STRING "Version number that will be placed into the clang executable, in the form XX.YY") set(LIBCLANG_LIBRARY_VERSION ---------------- Please update the descriptions too, e.g. "in the form XX". Though upon reading it more closely, where "into the executable" is the version number placed? Isn't this meant as "into the clang executable name"? I would propose: "Major version number that will be appended to the clang executable name" https://reviews.llvm.org/D41808 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits