asb accepted this revision.
asb added a comment.
This revision is now accepted and ready to land.
Thanks, this looks good to me.
================
Comment at: lib/Basic/Targets/RISCV.cpp:62-70
+ if (HasD)
+ Builder.defineMacro("__riscv_flen", "64");
+ else if (HasF)
+ Builder.defineMacro("__riscv_flen", "32");
+
+ if (HasF || HasD) {
+ Builder.defineMacro("__riscv_fdiv");
----------------
We really are nitpicking now, but this could be written as below, which would
keep the F/D defines in one place.
```
if (HasF || HasD) {
Builder.defineMacro("__riscv_flen", HasD ? "64" : "32");
Builder.defineMacro("__riscv_fdiv");
Builder.defineMacro("__riscv_fsqrt");
}
```
Repository:
rC Clang
https://reviews.llvm.org/D44727
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
