timshen marked 5 inline comments as done. timshen added inline comments.
================ Comment at: libcxx/test/std/experimental/simd/simd.traits/is_simd_mask.pass.cpp:68 + +static_assert(!is_simd_mask<int>::value, ""); + ---------------- mclow.lists wrote: > How about a couple more negative tests here? > You've got `int`, how about `float`, and `std::string` and a few of the simd > types? > I used "UserType" instead of std::string, as I don't want to pull in the whole <string> header. I figured that UserType should serve the same purpose. https://reviews.llvm.org/D41148 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits