Hi Zinovy, The PS4 Windows bot is still failing to compile this file after your latest change. Can you take a look?
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/16316 FAILED: tools/clang/tools/extra/clang-tidy/bugprone/CMakeFiles/clangTidyBugproneModule.dir/ParentVirtualCallCheck.cpp.obj C:\PROGRA~2\MICROS~1.0\VC\bin\cl.exe /nologo /TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -D_HAS_EXCEPTIONS=0 -D_LARGEFILE_SOURCE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools\clang\tools\extra\clang-tidy\bugprone -IC:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\clang\tools\extra\clang-tidy\bugprone -IC:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\clang\include -Itools\clang\include -Iinclude -IC:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\include /DWIN32 /D_WINDOWS /Zc:inline /Zc:strictStrings /Oi /Zc:rvalueCast /W4 -wd4141 -wd4146 -wd4180 -wd4244 -wd4258 -wd4267 -wd4291 -wd4345 -wd4351 -wd4355 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4800 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4324 -w14062 -we4238 /MD /O2 /Ob2 -UNDEBUG /EHs-c- /GR- /showIncludes /Fotools\clang\tools\extra\clang-tidy\bugprone\CMakeFiles\clangTidyBugproneModule.dir\ParentVirtualCallCheck.cpp.obj /Fdtools\clang\tools\extra\clang-tidy\bugprone\CMakeFiles\clangTidyBugproneModule.dir\clangTidyBugproneModule.pdb /FS -c C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\clang\tools\extra\clang-tidy\bugprone\ParentVirtualCallCheck.cpp C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE\algorithm(95): error C2719: '_Pred': formal parameter with requested alignment of 8 won't be aligned C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\clang\tools\extra\clang-tidy\bugprone\ParentVirtualCallCheck.cpp(36): note: see reference to function template instantiation '_InIt *std::find_if<IteratorT,clang::tidy::bugprone::isParentOf::<lambda_a9403013cb93abb282e252d6bc40ec07>>(_InIt,_InIt,_Pr)' being compiled with [ _InIt=clang::CXXRecordDecl::base_class_const_iterator, IteratorT=clang::CXXRecordDecl::base_class_const_iterator, _Pr=clang::tidy::bugprone::isParentOf::<lambda_a9403013cb93abb282e252d6bc40ec07> ] Douglas Yung > -----Original Message----- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of > Zinovy Nis via cfe-commits > Sent: Friday, April 06, 2018 14:00 > To: cfe-commits@lists.llvm.org > Subject: [clang-tools-extra] r329454 - [clang-tidy] One more fix compilation > for ParentVirtualCallCheck.cpp: find_if predicate > > Author: zinovy.nis > Date: Fri Apr 6 14:00:18 2018 > New Revision: 329454 > > URL: http://llvm.org/viewvc/llvm-project?rev=329454&view=rev > Log: > [clang-tidy] One more fix compilation for ParentVirtualCallCheck.cpp: find_if > predicate > > > Modified: > clang-tools-extra/trunk/clang-tidy/bugprone/ParentVirtualCallCheck.cpp > > Modified: clang-tools-extra/trunk/clang- > tidy/bugprone/ParentVirtualCallCheck.cpp > URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang- > tidy/bugprone/ParentVirtualCallCheck.cpp?rev=329454&r1=329453&r2=329454&view=d > iff > ============================================================================== > --- clang-tools-extra/trunk/clang-tidy/bugprone/ParentVirtualCallCheck.cpp > (original) > +++ clang-tools-extra/trunk/clang-tidy/bugprone/ParentVirtualCallCheck.c > +++ pp Fri Apr 6 14:00:18 2018 > @@ -76,8 +76,11 @@ static std::string getNameAsString(const static > std::string getExprAsString(const clang::Expr &E, > clang::ASTContext &AC) { > std::string Text = tooling::fixit::getText(E, AC).str(); > - Text.erase(std::remove_if(Text.begin(), Text.end(), std::isspace), > - Text.end()); > + Text.erase( > + std::remove_if( > + Text.begin(), Text.end(), > + [](char c) { return std::isspace(static_cast<unsigned char>(c)); > }), > + Text.end()); > return Text; > } > > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
