aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LG aside from a diagnostic wording nit. ================ Comment at: clang-tidy/hicpp/SignedBitwiseCheck.cpp:92 + if (N.getNodeAs<NamedDecl>("std_type")) + diag(Location, "shifting a value of the standardized bitmask types"); + else ---------------- How about: "shifting a value of bitmask type" Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45414 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits