whisperity requested changes to this revision.
whisperity added subscribers: gsd, dkrupp, o.gyorgy.
whisperity added a comment.
This revision now requires changes to proceed.
Sorry, one comment has gone missing meanwhile, I'm still getting used to this
interface and hit //Submit// early.
================
Comment at: test/Analysis/ctor-uninitialized-member-inheritance.cpp:24
+ : NonPolymorphicLeft1(int{}) {
+ y = 420;
+ z = 420;
----------------
The literal `420` is repeated //everywhere// in this file. I think this (the
same value appearing over and over again) will make debugging bad if something
goes haywire and one has to look at memory dumps, control-flow-graphs, etc.
https://reviews.llvm.org/D45532
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
