yaxunl marked 4 inline comments as done. yaxunl added inline comments.
================ Comment at: lib/Frontend/CompilerInvocation.cpp:2109 + Opts.HIP = true; + } + ---------------- rjmccall wrote: > Why is this done here? We infer the language mode from the input kind > somewhere else. It is usually done through CompilerInvocation::setLangDefaults. However, HIP does not have its own input kind nor is it defined as a language standard. Therefore it cannot use CompilerInvocation::setLangDefaults to set Opts.HIP. https://reviews.llvm.org/D44984 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits