EricWF marked 3 inline comments as done.
EricWF added inline comments.
================
Comment at: lib/Sema/SemaExpr.cpp:9816
+ RHS = S.ImpCastExprToType(RHS.get(), Type, CK_BitCast);
+ } else {
+ // C++2a [expr.spaceship]p4
----------------
rsmith wrote:
> We still need to apply the usual arithmetic conversions after converting
> enumerations to their underlying types (eg, `<=>` on `enum E : char` converts
> the operands first to `char` then to `int`). You could remove the `else` here
> and make this stuff unconditional, but it's probably better to sidestep the
> extra work and convert directly to the promoted type of the enum's underlying
> type.
Do we still do usual arithmetic conversions if we have two enumerations of the
same type?
https://reviews.llvm.org/D45476
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
