sammccall added a comment. Sorry, missed this. Just a few leftovers from removing the line/col conversion code. Then ship it!
================ Comment at: clangd/ClangdServer.h:166 + // FIXME: Remove this parameter when the index has line/col. + const DraftStore &DS, + Callback<std::vector<SymbolInformation>> CB); ---------------- DraftStore is now unused and can be dropped :-) (also the forward decl of it) ================ Comment at: clangd/FindSymbols.cpp:11 + +#include "DraftStore.h" +#include "Logger.h" ---------------- dead include ================ Comment at: clangd/FindSymbols.h:13 +//===----------------------------------------------------------------------===// +#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANGD_WORKSPACESYMBOL_H +#define LLVM_CLANG_TOOLS_EXTRA_CLANGD_WORKSPACESYMBOL_H ---------------- nit: header guards no longer match filename ================ Comment at: clangd/FindSymbols.h:24 +class SymbolIndex; +class DraftStore; + ---------------- dead forward decl (and the VirtualFileSystem and IntrusiveRefCntPtr includes) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44882 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
