yaxunl added a comment. In https://reviews.llvm.org/D45489#1071177, @tra wrote:
> In https://reviews.llvm.org/D45489#1071044, @yaxunl wrote: > > > In https://reviews.llvm.org/D45489#1070929, @yaxunl wrote: > > > > > In https://reviews.llvm.org/D45489#1070470, @tra wrote: > > > > > > > I'm getting confused about the order of the patches. > > > > The patch stack phabricator displays in this patch is different > > > > compared to the stack in https://reviews.llvm.org/D44984. Which one > > > > should I trust? > > > > > > > > > Sorry I think I may misunderstand the parent/child relation between > > > reviews. I thought a review depends on its parent reviews, i.e., parent > > > reviews should be committed first. Is that correct? Thanks. > > > > > > I think it is just visual difference. The relations are the same. > > > Would it be possible to arrange the changes in order in which you apply them > in the tree you are working on? If I want to try (partially) apply your > parches in my tree, it would help to know that what I get matches your setup. > Patch relationships as they are right now make intended order ambiguous. I reordered them as a simple linear relation. In the stack display, the patches should be applied from bottom to top. https://reviews.llvm.org/D45489 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
