sdardis requested changes to this revision. sdardis added a comment. This revision now requires changes to proceed.
A quick comment on the error message, inlined. It's about the quality of the diagnostics. ================ Comment at: include/clang/Basic/DiagnosticDriverKinds.td:336-337 +def warn_drv_unsupported_pic : Warning< + "ignoring '-fno-pic' option as it cannot be used with " + "-mabicalls and the N64 ABI">, InGroup<OptionIgnored>; ---------------- Can you fine tune this error message to say: "ignoring '-fno-pic' option as it cannot be used with explicit use of -mabicalls and the N64 ABI" when -mabicalls is used on the commandline and: "ignoring '-fno-pic' option as it cannot be used with implicit use of -mabicalls and the N64 ABI" when -mno-abicalls and -mabicalls are not present. You should also report the precise pic/PIC/pie/PIE option used in the error message. You should be able to get it from the argument directly: http://llvm.org/doxygen/classllvm_1_1opt_1_1Arg.html Repository: rC Clang https://reviews.llvm.org/D44684 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
