a.sidorin added inline comments.
================
Comment at: lib/StaticAnalyzer/Checkers/CtorUninitializedMemberChecker.cpp:72
+ const FieldDecl *getEndOfChain() const { return Chain.back()->getDecl(); }
+ template <unsigned Size> void toString(SmallString<Size> &Buf) const;
+ friend struct FieldChainInfoComparator;
----------------
This can be rewritten like `void toString(SmallVectorImpl<char> &Buf) const;
================
Comment at: lib/StaticAnalyzer/Checkers/CtorUninitializedMemberChecker.cpp:306
+
+ const RecordDecl *RD =
+ R->getValueType()->getAs<RecordType>()->getDecl()->getDefinition();
----------------
What will happen if we analyze a member which is a pointer to a structure type
and the structure is of incomplete type?
================
Comment at: lib/StaticAnalyzer/Checkers/CtorUninitializedMemberChecker.cpp:534
+
+ while (T.getTypePtrOrNull()) {
+ if (T->isVoidPointerType())
----------------
while (!T.isNull())
================
Comment at: test/Analysis/ctor-uninitialized-member.cpp:554
+
+void f23p15() {
+ void *vptr = malloc(sizeof(int));
----------------
Could you please explain what is the logic of test naming?
https://reviews.llvm.org/D45532
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
