jdenny added a comment.

In https://reviews.llvm.org/D45093#1087652, @aaron.ballman wrote:

> This approach generally looks good to me, but I'd like @rsmith's opinion on 
> whether we should be trying to make -ast-print have good source fidelity or 
> not. I was under the impression we wanted -ast-print to faithfully reproduce 
> code at least as a low priority desire, but it sounds like it may only be 
> intended as an approximation of the user's source code, so adding extra 
> machinery to support better fidelity may be more maintenance burden than it's 
> worth.


Thanks for your comment.  Give the discussion in 
https://reviews.llvm.org/D45463, it seems I need a more precise understanding 
of the purpose of -ast-print before I write any more fixes like these.


https://reviews.llvm.org/D45093



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D45093: [... Joel E. Denny via Phabricator via cfe-commits

Reply via email to