[PATCH] D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type

[Petr Hosek via Phabricator via cfe-commits]

phosek added inline comments.


================
Comment at: lib/Index/USRGeneration.cpp:691
+        case BuiltinType::ULongAccum:
+          llvm_unreachable("No USR name mangling for fixed point types.");
         case BuiltinType::Float16:
----------------
We need some solution for fixed point types.


================
Comment at: lib/Sema/SemaType.cpp:1391
+    if (S.getLangOpts().CPlusPlus) {
+      S.Diag(DS.getTypeSpecTypeLoc(), diag::err_fixed_point_only_allowed_in_c);
+    }
----------------
Shouldn't there be a break after this line?


https://reviews.llvm.org/D46084



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits