juliehockett added inline comments.
================
Comment at: clang-doc/generators/Generators.h:49
+
+class GeneratorFactory {
+public:
----------------
ioeric wrote:
> ioeric wrote:
> > Please add documentation and explain why this is needed.
> If you plan to plugin in more generators (e.g. in your customized build of
> clang-doc), consider using `llvm::Registry` which allows you to link in new
> generators without having to modify code. See
> `clang::clangd::URISchemeRegistry` for sample usage.
Oh cool -- didn't know about that. Thanks!
================
Comment at: clang-doc/generators/YAMLGenerator.cpp:223
+
+template <> struct MappingTraits<std::unique_ptr<CommentInfo>> {
+ static void mapping(IO &IO, std::unique_ptr<CommentInfo> &I) {
----------------
ioeric wrote:
> YAML mapping for `unique_ptr` is a bit unusual. I wonder whether this would
> work all the time e.g. if the unique_ptr has not been allocated.
Mmm yes it's a little weird -- that said, is there a better way emit the info
given a pointer?
https://reviews.llvm.org/D43667
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
