NoQ added a comment.
Refactor everything to address review comments.
================
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:123
+/// AST nodes.
+class ConstructedObjectKey : public ConstructedObjectKeyImpl {
+ const void *getAnyASTNodePtr() const {
----------------
george.karpenkov wrote:
> sorry I find that very confusing, and I think the previous version was better
> (prefer composition over inheritance)
Ok, so, i mean, i don't think it would be faster, i really hope the compiler
would know how to inline `std::pair` methods. I think converting to a
`std::pair` or `std::tuple` is a fairly standard trick to avoid `x < rhs.x ||
(x == rhs.x && y < rhs.y)` kind of code. But with inheritance we at least have
boilerplate operators sorted out for free.
May i leave the actual previous version around without fixing it?^^
https://reviews.llvm.org/D47350
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
