erik.pilkington added a comment.
In https://reviews.llvm.org/D47607#1118547, @EricWF wrote:
> I should have asked, have we actually seen a midcompile caused by this? Is
> there a reproducer? Or is this purerly speculative?
Nope, pure speculation. I still think we should still fix this though.
================
Comment at: libcxx/include/map:648
+ _LIBCPP_INLINE_VISIBILITY
+ __nc_ref_pair_type __ref()
+ {
----------------
EricWF wrote:
> I think `__ref` can be private.
That's true for this patch, but I'm planning on using `__ref` in
`__node_handle` to implement key() and mapped() so we don't have to duplicate
the const cast.
https://reviews.llvm.org/D47607
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
