jmorse marked 2 inline comments as done.
jmorse added inline comments.
================
Comment at: lib/AST/ASTContext.cpp:8588
+ Expr *E = VAT->getSizeExpr();
+ if (E && VAT->getSizeExpr()->isIntegerConstantExpr(TheInt, *this))
+ return std::make_pair(true, TheInt);
----------------
efriedma wrote:
> `E && E->isIntegerConstantExpr`?
Done
================
Comment at: lib/AST/ASTContext.cpp:8603
+ std::tie(HaveRSize, RSize) = SizeFetch(RVAT, RCAT);
+ if (HaveLSize && HaveRSize && LSize != RSize)
+ return {}; // Definite, but unequal, array dimension
----------------
efriedma wrote:
> The != will hit an assertion failure if LSize and RSize don't have the same
> bitwidth.
Erk -- replaced with APInt::isSameValue.
https://reviews.llvm.org/D47628
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
