sammccall accepted this revision. sammccall added inline comments.
================ Comment at: clangd/index/SymbolCollector.cpp:302 + // A declaration created for a friend declaration should not be used as the + // canonical declaration in the index. If D is a defintion and is not OrigD, + // D would have been picked as the canonical declaration, if it has been ---------------- I'd rephrase the second sentence as "Use OrigD instead, unless we've already picked a replacement for D". up to you Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47623 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
