aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
Aside from a minor commenting nit, this LGTM. ================ Comment at: clang-tidy/utils/ExprMutationAnalyzer.cpp:78-81 + // TODO: also handle these cases: + // - `Exp` is the ControllingExpr of a GenericSelectionExpr + // - `Exp` is within an expression (other than glvalue of a polymorphic class + // type) operand of typeid. ---------------- I think this comment is stale now. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45679 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
