aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM!
================
Comment at: clang-tidy/ClangTidyProfiling.cpp:47
+void ClangTidyProfiling::printAsJSON(llvm::raw_ostream &OS) {
+ OS << "{\n";
----------------
lebedev.ri wrote:
> aaron.ballman wrote:
> > I'm not keen that we call this `printAsJSON()` when the docs talk about
> > writing out YAML. While all JSON is valid YAML, that feels like trivia we
> > shouldn't encode in the function name. What do you think to renaming to
> > `printAsYAML()` instead?
> But the actual printer is called `TG->printJSONValues()`..
> Let's go the other way around, and canonicalize to JSON.
Even better!
Repository:
rL LLVM
https://reviews.llvm.org/D46602
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
