[PATCH] D47375: [Driver] Add flag "--dependent-lib=..." when enabling asan or ubsan on PS4.

[Filipe Cabecinhas via Phabricator via cfe-commits]

filcab added a comment.

I have a minor nit + what Paul mentioned (missing a `-NOT` check). Otherwise 
LGTM.



================
Comment at: lib/Driver/ToolChains/Clang.cpp:3690
 
-  // Add runtime flag for PS4 when PGO or Coverage are enabled.
-  if (RawTriple.isPS4CPU())
+  // Add runtime flag for PS4 when PGO or Coverage or sanitizers are enabled.
+  if (RawTriple.isPS4CPU()) {
----------------
Nit: `PGO, coverage, or sanitizers`


Repository:
  rC Clang

https://reviews.llvm.org/D47375



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits