ruiu added inline comments.
================ Comment at: llvm/lib/Support/Windows/Process.inc:240 + Filename.assign(Base.begin(), Base.end()); + return ec; } ---------------- The intention of the code is to return a success, so it is less confusing if you directly return a success (i.e. std::error_code()) ================ Comment at: llvm/lib/Support/Windows/Process.inc:262 - LocalFree(UnicodeCommandLine); + SmallVector<char, MAX_PATH> Arg0(Args[0], Args[0] + strlen(Args[0])), Filename; + sys::path::remove_filename(Arg0); ---------------- Looks like defining a variable on at a time is more common than defining two variables in one line. https://reviews.llvm.org/D47578 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
