This should be fixed now with r334239. In for a penny, in for a pound. On Wed, Jun 6, 2018 at 6:09 PM Grang, Mandeep Singh <mgr...@codeaurora.org> wrote:
> @rnk I tried building spec2000/eon for Windows ARM64 and ran into these > errors: > > use of undeclared identifier '_interlockedbittestandset_acq' > use of undeclared identifier '_interlockedbittestandset_rel' > use of undeclared identifier '_interlockedbittestandset_nf' > > I see that you have removed them in your patch. Apparently they are needed > (at least for ARM64 Win). > > --Mandeep > > On 6/5/2018 11:01 AM, Reid Kleckner via cfe-commits wrote: > > On Tue, Jun 5, 2018 at 2:33 AM Martin Storsjö <mar...@martin.st> wrote: > >> > // Many of MSVC builtins are on both x64 and ARM; to avoid repeating >> code, we >> > // handle them here. >> >> This doesn't seem thought through wrt non-x86 architectures. I'm not sure >> if there's any similar suitable instruction to use on ARM/AArch64, but we >> should at the very least fall back to doing whatever we did before this >> change for anything not x86. >> > > I'll go back and take a look, but I'm not convinced that what we did > before was correct for ARM either. I'm installing the Visual C++ aarch64 > compiler now so I can make sure we get it right. > > > _______________________________________________ > cfe-commits mailing > listcfe-comm...@lists.llvm.orghttp://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits > > >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits