george.karpenkov added subscribers: aaron.ballman, alexfh. george.karpenkov added a comment. Herald added a subscriber: mikhail.ramalho.
Getting there! Sorry for the delay. Would it be possible to rewrite the remaining imperative code using matchers? 👍 on defining your own matcher. However, that would probably need to go in a separate PR (with tests), @alexfh and @aaron.ballman can help with the review. ================ Comment at: lib/StaticAnalyzer/Checkers/DeadStatusChecker.cpp:33 + + const Expr *hasNullptr(const BinaryOperator *BO) const { + const Expr *ret = nullptr; ---------------- Could this be rewritten as a matcher instead? Surely there must be one comparing the literal to null? Repository: rC Clang https://reviews.llvm.org/D47554 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits