SjoerdMeijer added a comment. Nits title:
- Think you can simplify the title to something along the lines of: "[AArch64] Support the FP16 VCVTA_U16 intrinsic". No need to mention tests are added in the subject (tests should always be added). Nits summary: - Arm v8.2a -> Armv8.2-A - Aarch64 -> AArch64 - No need to mention "tested and works using ninja check"; this is obvious and should always be done. - This is a bit vague: "Added support for existing IP". I think you can reduce the summary to just: "Added support for the vcvta_u16_f16 instrinsic for FP16 Armv8.2-A" ================ Comment at: CodeGen/arm-v8.2a-neon-intrinsics.c:170 +// CHECK: ret <4 x i16> [[VCVT]] +int16x4_t test_vcvta_u16_f16 (float16x4_t a) { + return vcvta_u16_f16(a); ---------------- Is this exactly the same test also added in aarch64-v8.2a-neon-intrinsics.c? Repository: rC Clang https://reviews.llvm.org/D48119 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits