For that particular test I wanted to check the store value on each declaration but tests failed on 4 different machines where for global variables. On these machines `dso_local` was not included in the IR output and x86_64-scei-ps4-ubuntu-fast was one of them. My quick fix to address this was using a regex to capture the `dso_local` and adding x86_64-scei-ps4-ubuntu-fast as a target to make sure the test passed for it.
Today I ran into a similar issue with my tests where instead s390x added `common dso_local` which I couldn't easily catch with my current regex. The quick hack for this was just testing only on linux, but forgot to remove the x86_64-scei-ps4-ubuntu-fast run. I will remove this in a future patch since just forcing the first run to target linux fixes my initial problem. - Leo On Wed, Jun 20, 2018 at 12:55 PM <paul.robin...@sony.com> wrote: > > (Using the right commits list this time...) > > See inline (same as previous). > > > -----Original Message----- > > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of > > Leonard Chan via cfe-commits > > Sent: Wednesday, June 20, 2018 3:34 PM > > To: cfe-commits@lists.llvm.org > > Subject: r335159 - Fixed test in prior build where FileCheck tried to > > match against > > > > Author: leonardchan > > Date: Wed Jun 20 12:34:05 2018 > > New Revision: 335159 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=335159&view=rev > > Log: > > Fixed test in prior build where FileCheck tried to match against > > `common` when declaring a global variable when we primarily care about > > the value assigned in the test. > > > > Modified: > > cfe/trunk/test/Frontend/fixed_point_declarations.c > > > > Modified: cfe/trunk/test/Frontend/fixed_point_declarations.c > > URL: http://llvm.org/viewvc/llvm- > > project/cfe/trunk/test/Frontend/fixed_point_declarations.c?rev=335159&r1=3 > > 35158&r2=335159&view=diff > > ========================================================================== > > ==== > > --- cfe/trunk/test/Frontend/fixed_point_declarations.c (original) > > +++ cfe/trunk/test/Frontend/fixed_point_declarations.c Wed Jun 20 12:34:05 > > 2018 > > @@ -1,4 +1,4 @@ > > -// RUN: %clang -ffixed-point -S -emit-llvm %s -o - | FileCheck %s > > +// RUN: %clang -ffixed-point -S -emit-llvm %s -o - --target=x86_64-linux > > | FileCheck %s > > // RUN: %clang -ffixed-point -S -emit-llvm %s -o - --target=x86_64-scei- > > ps4-ubuntu-fast | FileCheck %s > > By the way, "x86_64-scei-ps4-ubuntu-fast" is not a real triple. The PS4 > triple is "x86_64-scei-ps4" (although there is an ubuntu-fast bot, which > might be where the confusion arises). > > Is there any particular reason to want to use the PS4 triple in addition > to Linux? I haven't really been watching the fixed-point stuff. > Thanks, > --paulr > PS4 code owner > > > > > // Primary fixed point types > > > > > > _______________________________________________ > > cfe-commits mailing list > > cfe-commits@lists.llvm.org > > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits