Hi Stella,
On Wed, Jun 20, 2018 at 3:44 PM Stella Stamenova via Phabricator
<revi...@reviews.llvm.org> wrote:
>
> stella.stamenova added a comment.
>
> This breaks the clang tests on Windows when building using Visual Studio as
> none of the updated tests can find hmaptool.
Yes. I contacted Galina about that but maybe it was the wrong person
to contact.
> Visual Studio as a generator supports multiple configurations, so its bin
> folder varies depending on the build configuration. The generalized version
> of the bin directory is: ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin. This is
> actually the proper bin directory to use for any generator because
> ${CMAKE_CFG_INTDIR} is simply '.' when the generator (such as ninja) doesn't
> support multiple configurations.
Good to know.
> I can look into a fix and submit a change for review tomorrow if you can't,
> but in the future please make sure to use the full path to the bin directory
> (${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin) to avoid missing a generator.
I'll try to fix it now. Thanks for the heads up!
>
>
> Repository:
> rC Clang
>
> https://reviews.llvm.org/D46485
>
>
>
--
Bruno Cardoso Lopes
http://www.brunocardoso.cc
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
