ioeric added inline comments.
================ Comment at: tools/clang-format/ClangFormat.cpp:67 static cl::opt<std::string> FallbackStyle("fallback-style", cl::desc("The name of the predefined style used as a\n" ---------------- sammccall wrote: > My only question is if we want to do the same with DefaultFallbackStyle. > > Not because we have a use case for changing it right now, but because it's > another string that callers of getStyle() have to hard-code. In our internal > codebase, some pass "LLVM", some pass "Google", and some make it an option. Can't see a reason not to. This should help get rid of more hardcode. Repository: rC Clang https://reviews.llvm.org/D48492 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits