t.p.northover added a comment.

> I'd rather not put target names in API functions. The meaning of that field 
> is pretty target independent ("alignment of type, before alignment 
> adjustments")

Except that rule only applies to aggregates. Scalar types get their alignment 
adjusted anyway I believe. The definition is ridiculously arbitrary.

> If we use it only in ARM/AArch64 we can put a comment in that sense and maybe 
> rename it to `UnadjustedAlignement` or something else more descriptive than 
> `NaturalAlignement`?

I could just about live with that (or `UnnaturalAlignment`, though perhaps best 
not).


https://reviews.llvm.org/D46013



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to