thakis added a comment.
Still looks good, ship it! One more suggestion about additional test coverage
(but maybe it's already there and I'm just missing it).
================
Comment at: test/CodeGen/pch-dllexport.cpp:55
+template <typename T> void __declspec(dllexport)
explicitInstantiationDefAfterDecl(T) {}
+extern template void explicitInstantiationDefAfterDecl<int>(int);
+
----------------
This has two interesting cases:
1. An explicit instantiation declaration.
2. An explicit instantiation definition.
You have a test for 2, but not for 1, as far as I can tell (?). For 1, the
inline function from the pch-obj should be used (which probably already works;
if not a FIXME is enough).
https://reviews.llvm.org/D48426
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
