rnkovacs added inline comments.
================ Comment at: test/Analysis/dangling-internal-buffer.cpp:10 const CharT *c_str(); + const CharT *data(); }; ---------------- xazax.hun wrote: > Note that these methods are const according to the standard. Even if it does > not make any difference for this check we should follow the signatures. Also, > from c++17 there is a non-const overload of data. Oh, right, thanks. Fixed here and in D48522. https://reviews.llvm.org/D48532 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits