ilya-biryukov added inline comments.

================
Comment at: clangd/CodeCompletionStrings.cpp:172
   // get this declaration, so we don't show documentation in that case.
   if (Result.Kind != CodeCompletionResult::RK_Declaration)
     return "";
----------------
sammccall wrote:
> while here, should this be if (Result.Declaration)? I make this mistake a 
> lot...
Looking at the FIXME above, it seems we might show a different comment from the 
one returned by clang's code completion.
I'll double-check if we do the right thing there and will try to do `if 
(!Result.Declaration)` in a follow-up patch.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D48211



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to