vsapsai added a comment. In https://reviews.llvm.org/D48342#1148751, @mclow.lists wrote:
> I want to point out that this code (not -necessarily- this patch, but where > it lives) needs to be rewritten. > > There is no prohibition on users specializing `allocator_traits` for their > allocators, and yet libc++'s vector depends on the existence of > `allocator_traits<Allocator>::__construct_range_forward` (among other things). Marshall, do you agree to have such rewrite to be done separately? It seems to me fairly involved and I don't want it to block other changes. And for this change I suggest observing how it develops. If it is fairly small and isolated, I think it would be useful to have it before the more substantial `allocator_traits` rewrite. https://reviews.llvm.org/D48342 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
