ilya-biryukov added a comment.

Not sure about two things:

- Using PreprocessorOptions for plumbing this setting. I'd rather put it into 
FrontendOptions, but there seems to be no way to get those in the ASTWriter... 
Happy to search for the alternatives
- Lack of tests. I'm not sure how to properly test it in clang. I've added 
asserts in clangd, see the follow-up https://reviews.llvm.org/D48943. But happy 
to look into writing actual tests if that looks important.

Also not sure if someone else should look at this change, suggestions for 
reviewers are very welcome!


Repository:
  rC Clang

https://reviews.llvm.org/D48942



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to