jfb accepted this revision. jfb added a comment. This revision is now accepted and ready to land.
LGTM after a few questions. ================ Comment at: include/clang/Analysis/Analyses/FormatString.h:265 + enum class TypeKind { Unspecified, SizeT, PtrdiffT }; + TypeKind TK = TypeKind::Unspecified; ---------------- "unspecified" seems odd because it *is* specified, we just don't care. How about something like "NothingSpecial" or "DontCare"? ================ Comment at: test/SemaObjC/format-size-spec-nsinteger.m:4 +// RUN: %clang_cc1 -triple thumbv7k-apple-watchos2.0.0 -fsyntax-only -fblocks -verify %s +// RUN: %clang_cc1 -triple thumbv7k-apple-watchos2.0.0 -fsyntax-only -fblocks -verify -Wformat-pedantic -DPEDANTIC %s ---------------- We use a bunch of different triples to test WatchOS: 5 thumbv7k-apple-watchos2.0 3 i386-apple-watchos4 2 x86_64-apple-watchos 2 thumbv7k-apple-watchos 2 armv7k-apple-watchos3.0.0 2 armv7k-apple-watchos2.0 2 armv7k-apple-watchos 1 x86_64-apple-watchos-simulator 1 thumbv7k-apple-watchos1.0 1 i686-apple-watchos 1 i386-apple-watchos3.0-simulator 1 i386-apple-watchos3 1 i386-apple-watchos2.1 1 i386-apple-watchos2.0-simulator 1 i386-apple-watchos2.0 1 i386-apple-watchos-simulator 1 i386-apple-watchos 1 armv7k-apple-watchos2.1 1 armv7-apple-watchos 1 arm64-apple-watchos 1 aarch64-apple-watchos Do we care about v7k only for this test? Repository: rC Clang https://reviews.llvm.org/D48852 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits