mclow.lists added inline comments.
================ Comment at: include/charconv:244 + static _LIBCPP_INLINE_VISIBILITY char const* + read(char const* __p, char const* __ep, type& __a, type& __b) + { ---------------- Same comment as above about `read` and `inner_product` - they need to be "ugly names" ================ Comment at: include/charconv:358 + + auto __gen_digit = [](_Tp __c) { + return "0123456789abcdefghijklmnopqrstuvwxyz"[__c]; ---------------- I just want you to reassure me here - this lambda gets inlined, right? Repository: rCXX libc++ https://reviews.llvm.org/D41458 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits